Skip to content

fix(test): allow dash/underscore separated names #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

cironunes
Copy link
Member

issue was found whenever creating projects with names like: 'project-2' or
'project_2' Karma weren't able to find the app files.

@IgorMinar can you review?

issue was found whenever creating projects with names like: 'project-2' or
'project_2' Karma weren't able to find the app files.
@IgorMinar
Copy link
Contributor

Lgtm
On Thu, Nov 26, 2015 at 9:54 AM Ciro Nunes [email protected] wrote:

issue was found whenever creating projects with names like: 'project-2' or
'project_2' Karma weren't able to find the app files.

@IgorMinar https://github.com/IgorMinar can you review?

You can view, comment on, or merge this pull request online at:

#71
Commit Summary

  • fix(test): allow dash/underscore separated names

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#71.

@cironunes cironunes merged commit 1f21582 into angular:master Nov 26, 2015
@cironunes cironunes deleted the karma-support-dash branch January 31, 2016 14:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants